Please review JDK-8062490

Marcus Lagergren marcus.lagergren at oracle.com
Mon Nov 3 14:11:12 UTC 2014


Good questions. I can certainly do those trivial things in the next checkin. I didn’t want to change overly much for 8u40.

> On 03 Nov 2014, at 15:08, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
> 
> On 03.11.2014 16:57, Marcus Lagergren wrote:
>> UntouchedArrayData didn’t expand to SparseArrayData directly, for
>> large index, but rather through VERY LARGE IntArrayDatas. That, of
>> course, is fatal.
>> 
>> Webrev: http://cr.openjdk.java.net/~lagergren/8062490/
> 
> Two questions about the same line:
>   39     static final long MAX_DENSE_LENGTH = 16 * 512 * 1024;
> 
> 1) This is a weird magic number: should be 8 * 1024 * 1024?
> 2) Why not make it "int MAX_DENSE_LENGTH" and remove the asserts in
> static initializer?
> 
> -Aleksey.
> 



More information about the nashorn-dev mailing list