Review request for JDK-8060011: Concatenating an array and converting it to Java gives wrong result
Marcus Lagergren
marcus.lagergren at oracle.com
Mon Oct 13 13:26:35 UTC 2014
+1. This looks very nice, Hannes.
/M
On 13 Oct 2014, at 15:22, Hannes Wallnoefer <hannes.wallnoefer at oracle.com> wrote:
> Please review JDK-8060011: Concatenating an array and converting it to Java gives wrong result:
>
> http://cr.openjdk.java.net/~hannesw/8060011/
>
> Note that in addition to fixing the actual bug, the webrev lowers the maximum for various java array index operations from Integer.MAX_VALUE to (Integer.MAX_VALUE - 1). I'm pretty sure this is correct, but given that various VMs have lower maximum array sizes and would throw OOM with common heap sizes, it seems impossible to write a practical test for this.
>
> Hannes
More information about the nashorn-dev
mailing list