Review request for JDK-8060242

Hannes Wallnoefer hannes.wallnoefer at oracle.com
Tue Oct 14 07:46:59 UTC 2014


+1

There's a blank line missing between methods in NativeUint8Array.java 
after getLongOptimistic.

Hannes

Am 2014-10-13 um 20:34 schrieb Attila Szegedi:
> Please review JDK-8060242 at <http://cr.openjdk.java.net/~attila/8060242/webrev.00> for <https://bugs.openjdk.java.net/browse/JDK-8060242>
>
> The fix is mostly in the TypeEvaluator.java, the rest is just plumbing (ArrayBufferView has to be public so I can us it with instanceof; array data subclasses for buffer views need to support optimistic operations; Int/Long/Number/ObjectArrayData now inherit they getOptimisticType() from ContinuousArrayData; finally there was a genuine data type bug where NativeUint32Array reported its array element type to be int instead of long).
>
> Thanks,
>    Attila.



More information about the nashorn-dev mailing list