Review request for JDK-8062132: Nashorn incorrectly binds "this" for constructor created by another function

Marcus Lagergren marcus.lagergren at oracle.com
Fri Oct 31 16:40:17 UTC 2014


Ok that’s good. Messing with the prototype history cache could cause side effects that do anything anywhere, so I was a bit scared. ;) Glad it worked out.

/M

> On 31 Oct 2014, at 13:24, Hannes Wallnoefer <hannes.wallnoefer at oracle.com> wrote:
> 
> I don't see any change in performance. Sundar was concerned about heap usage with test262, but I saw no difference there as well.
> 
> Hannes
> 
> 
> Am 2014-10-31 um 10:11 schrieb Marcus Lagergren:
>> Any performance implications? Otherwise +1
>> 
>> /M
>> 
>>> On 30 Oct 2014, at 17:00, Hannes Wallnoefer <hannes.wallnoefer at oracle.com> wrote:
>>> 
>>> Please review JDK-8062132: Nashorn incorrectly binds "this" for constructor created by another function:
>>> 
>>> http://cr.openjdk.java.net/~hannesw/8062132/
>>> 
>>> thanks,
>>> Hannes
> 



More information about the nashorn-dev mailing list