Please review JDK-8059123

Aleksey Shipilev aleksey.shipilev at oracle.com
Fri Sep 26 11:10:09 UTC 2014


On 09/26/2014 03:03 PM, Marcus Lagergren wrote:
> Actually after rerunning 100 times, I think the changed speed is
> already inside the standard deviation. It appears that both
> constructors to UOE and RewriteException already pass the
> “writableStackTrace” parameter as false if we are not running in
> debug mode.  I understand that this is equivalent to overriding
> fillInStackTrace, right ?

That appears to be the case:

    protected Throwable(String message, Throwable cause,
                        boolean enableSuppression,
                        boolean writableStackTrace) {
        if (writableStackTrace) {
            fillInStackTrace();
        } else {
            stackTrace = null;
        }

Nice trick, btw, but works only if you extend Exception directly, and
not some known *Exception that insulates you from this Throwable
constructor.

I think you are already good for both UOE and Rewrite* exceptions.

-Aleksey.



More information about the nashorn-dev mailing list