RFR 8073733: TypeError messages with "call" and "new" could be improved

Attila Szegedi attila.szegedi at oracle.com
Tue Aug 4 13:18:38 UTC 2015


+1

> On Aug 4, 2015, at 2:40 PM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
> 
> Thanks for the review. Updated webrev is @ http://cr.openjdk.java.net/~sundar/8073733/webrev.01/
> 
> Thanks
> -Sundar
> 
> On 8/4/2015 5:53 PM, Attila Szegedi wrote:
>> You should use NameCodec.encode(msg) in MethodEmitter.dynamicCall. Other than that, looks okay.
>> 
>> Attila.
>> 
>>> On Aug 4, 2015, at 1:50 PM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
>>> 
>>> Please review http://cr.openjdk.java.net/~sundar/8073733/ for https://bugs.openjdk.java.net/browse/JDK-8073733
>>> 
>>> Improves "cannot call undfined" with name of the property that resulted in undefined value (better debugging clue).
>>> 
>>> Thanks,
>>> -Sundar
> 



More information about the nashorn-dev mailing list