RFR 8133347: Add makefiles support and basic session, persistence history navigation with jline
Erik Joelsson
erik.joelsson at oracle.com
Thu Aug 13 07:54:08 UTC 2015
Thanks, looks good!
/Erik
On 2015-08-13 09:51, Sundararajan Athijegannathan wrote:
> Updated only the "top" webrev:
>
> http://cr.openjdk.java.net/~sundar/8133347/top/webrev.01/
>
> Thanks,
> -Sundar
>
> On 8/13/2015 12:47 PM, Sundararajan Athijegannathan wrote:
>> Hi,
>>
>> Thanks. I'll fix it.
>>
>> -Sundar
>>
>> On 8/13/2015 12:43 PM, Erik Joelsson wrote:
>>> Hello Sundar,
>>>
>>> Build changes look ok. I would appreciate if you could avoid
>>> increasing the line length that much in make/Images.gmk though. It
>>> makes side by side comparisons difficult.
>>>
>>> /Erik
>>>
>>> On 2015-08-12 19:03, Sundararajan Athijegannathan wrote:
>>>> Hi,
>>>>
>>>> Please review changes for the bug:
>>>> https://bugs.openjdk.java.net/browse/JDK-8133347
>>>>
>>>> This is a subtask of "jjs should use jline"
>>>> https://bugs.openjdk.java.net/browse/JDK-8080678
>>>>
>>>> This subtask addresses infrastructure changes (module.xml,
>>>> makefiles, security policy) and basic jjs use of jline. In session
>>>> command history and persistent history are implemented. Old jjs
>>>> main class jdk.nashorn.tools.Shell is still available and that can
>>>> be used on non-desktop platforms such as "compact1". The new "jjs"
>>>> main class is jdk.nashorn.tools.jjs.Main subclasses Shell and adds
>>>> only support for interactive mode using jline internal API.
>>>>
>>>> jdk9-dev "top" repo webrev:
>>>> http://cr.openjdk.java.net/~sundar/8133347/top/webrev.00/
>>>> "jdk" repo webrev:
>>>> http://cr.openjdk.java.net/~sundar/8133347/jdk/webrev.00/
>>>> "nashorn" repo webrev:
>>>> http://cr.openjdk.java.net/~sundar/8133347/nashorn/webrev.00/
>>>>
>>>> Thanks,
>>>> -Sundar
>>>
>>
>
More information about the nashorn-dev
mailing list