RFR 8133777: Use file based persistence for history instead of preferences

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Tue Aug 18 06:01:35 UTC 2015


Hi Michael,

Thanks for the review. I'll update that.

Thanks
-Sundar

On 8/18/2015 9:48 AM, Michael Haupt wrote:
> Hi Sundar,
>
> lower-case thumbs up.
>
> Nit: In the "clear" case in HistoryObject.getMember(), I think hist::clear would work instead of the lambda.
>
> Best,
>
> Michael
>
>> Am 17.08.2015 um 17:54 schrieb Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com>:
>>
>> Hi,
>>
>> Please review http://cr.openjdk.java.net/~sundar/8133777/ for https://bugs.openjdk.java.net/browse/JDK-8133777
>>
>> Thanks,
>> -Sundar



More information about the nashorn-dev mailing list