RFR 8133872: Expression completion should work on contexts where an expression is accepted

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Tue Aug 18 23:39:19 UTC 2015


Hi,

I've updated this webrev slightly:

http://cr.openjdk.java.net/~sundar/8133872/webrev.01/

Changes from earlier webrev:

1) Added PartialParser interface rather than passing Main object to 
NashornCompleter.
2) Added key set to HistoryObject - so that "history." completion will 
work as expected.

Everything else remains the same.

Thanks,
-Sundar

On 8/18/2015 10:40 PM, Michael Haupt wrote:
> Hi Sundar,
>
> lower-case thumbs up!
>
> Best,
>
> Michael
>
>> Am 18.08.2015 um 10:04 schrieb Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com>:
>>
>> Please review http://cr.openjdk.java.net/~sundar/8133872/ for https://bugs.openjdk.java.net/browse/JDK-8133872
>>
>> Thanks,
>> -Sundar



More information about the nashorn-dev mailing list