RFR 8133872: Expression completion should work on contexts where an expression is accepted

[Hannes Wallnoefer]

Looks good!

Hannes

Am 2015-08-19 um 05:42 schrieb Sundararajan Athijegannathan:
> Please review updated webrev @ 
> http://cr.openjdk.java.net/~sundar/8133872/webrev.02/
>
> Thanks,
> -Sundar
>
> On 8/19/2015 8:31 AM, Sundararajan Athijegannathan wrote:
>> Thanks Hannes!
>>
>> Yes, that is a good suggestion. I initially had it in Main.java and 
>> refactored. Idea was to avoid exposing jdk.nashorn.internal.parser.* 
>> to "jdk.scripting.nashorn.shell" module. But, you're right. Better to 
>> move PartialParser interface to jdk.nashorn.tools package. I'll do 
>> that and will send another webrev.
>>
>> Thanks,
>> -Sundar
>>
>> On 8/19/2015 7:30 AM, Hannes Wallnoefer wrote:
>>> Great work, Sundar!
>>>
>>> One question I have: why did you put getLastExpressionStart in 
>>> Shell.java and make it protected there instead of implementing 
>>> PartialParser right there?
>>>
>>> Hannes
>>>
>>> Am 2015-08-19 um 01:39 schrieb Sundararajan Athijegannathan:
>>>> Hi,
>>>>
>>>> I've updated this webrev slightly:
>>>>
>>>> http://cr.openjdk.java.net/~sundar/8133872/webrev.01/
>>>>
>>>> Changes from earlier webrev:
>>>>
>>>> 1) Added PartialParser interface rather than passing Main object to 
>>>> NashornCompleter.
>>>> 2) Added key set to HistoryObject - so that "history." completion 
>>>> will work as expected.
>>>>
>>>> Everything else remains the same.
>>>>
>>>> Thanks,
>>>> -Sundar
>>>>
>>>> On 8/18/2015 10:40 PM, Michael Haupt wrote:
>>>>> Hi Sundar,
>>>>>
>>>>> lower-case thumbs up!
>>>>>
>>>>> Best,
>>>>>
>>>>> Michael
>>>>>
>>>>>> Am 18.08.2015 um 10:04 schrieb Sundararajan Athijegannathan 
>>>>>> <sundararajan.athijegannathan at oracle.com>:
>>>>>>
>>>>>> Please review http://cr.openjdk.java.net/~sundar/8133872/ for 
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8133872
>>>>>>
>>>>>> Thanks,
>>>>>> -Sundar
>>>>
>>>
>>
>