RFR 8133948: Add 'edit' function to allow external editing of scripts

[Jan Lahoda]

Seems fine to me. Yes, I think that, eventually, we should generalize 
what we need into jdk.internal.le, so that we don't have to maintain two 
copies of the code.

Jan

On 20.8.2015 16:05, Attila Szegedi wrote:
> +1
>
>> On Aug 20, 2015, at 3:11 PM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
>>
>> Hi,
>>
>> Please review the updated webrev (in place).
>>
>> http://cr.openjdk.java.net/~sundar/8133948/
>>
>> I tested this on Windows with external editors being notepad.exe, gvim.exe and internal editor.Thanks to Hannes for testing it on Ubuntu.
>>
>> As I mentioned earlier EditPad and ExternalEditor are cloned from Kulla project and modified to suit nashorn shell requirements. We can revisit and refactor code to jdk.internal.le module later.
>>
>> Thanks,
>> -Sundar
>>
>> On 8/20/2015 4:45 PM, Sundararajan Athijegannathan wrote:
>>> Please ignore this webrev. I'll update it in-place and send a review request later..
>>>
>>> Thanks
>>> -Sundar
>>>
>>> On 8/19/2015 10:02 PM, Sundararajan Athijegannathan wrote:
>>>> Forgot to CC Jan ...
>>>>
>>>> -Sundar
>>>>
>>>> On 8/19/2015 10:01 PM, Sundararajan Athijegannathan wrote:
>>>>> Please review http://cr.openjdk.java.net/~sundar/8133948/ for https://bugs.openjdk.java.net/browse/JDK-8133948
>>>>>
>>>>> Note: ExternalEditor and EditPad classes are from kulla/jshell code - modified to suite nashorn jjs. Perhaps eventually code could be refactored and reused from jdk.interanal.le.
>>>>>
>>>>> Thanks,
>>>>> -Sundar
>>>>
>>>
>>
>