RFR 8134279: jjs should support multiple line input to complete incomplete code

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Mon Aug 24 10:50:17 UTC 2015


Thanks Hannes! Updated and will go ahead with push. Updated webrev for 
the record is @ http://cr.openjdk.java.net/~sundar/8134279/webrev.01/

Thanks,
-Sundar

On 8/24/2015 4:03 PM, Hannes Wallnoefer wrote:
> That's another great addition to jjs. I've tested it on Linux and it 
> works fine.
>
> One suggestion: it would be nice if the secondary prompt would have 
> the same indentation as the primary one.
>
> Hannes
>
> Am 2015-08-24 um 06:06 schrieb Sundararajan Athijegannathan:
>> Please review http://cr.openjdk.java.net/~sundar/8134279/ for 
>> https://bugs.openjdk.java.net/browse/JDK-8134279
>>
>> PS. In addition to the enhancement, I'm fixing this line ->
>>
>> +        new LinkedHashMap<String, List<String>>(32, 0.75f, true) {
>>
>> in PackagesHelper to make sure the code compiles with jdk9 as well as 
>> jdk8u.
>>
>> Thanks,
>> -Sundar
>



More information about the nashorn-dev mailing list