RFR 8144841: Add a sample for pluggable dynalink linker for stream property on arrays and a REAMDE for linker samples

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Tue Dec 8 11:47:16 UTC 2015


Thanks Attila. I changed that and pushed it.

Yes, it seems that few operation extraction static methods would be useful.

-Sundar

On 12/8/2015 4:00 PM, Attila Szegedi wrote:
> A bit of a nitpick:
>
> if (getProp && name instanceof String) {
>      String nameStr = (String)name;
>      if (nameStr.equals("stream")) {
>
> can be replaced with
>
> if (getProp && “stream”.equals(name)) {
> Other than that, +1. Still very happy that you’re producing these 
> examples :-)
>
> I’m wondering if maybe “getFirstStandardOperation” would make sense to 
> add as a static method to StandardOperation…
>
> Attila.
>
>
>> On Dec 8, 2015, at 9:05 AM, Sundararajan Athijegannathan 
>> <sundararajan.athijegannathan at oracle.com 
>> <mailto:sundararajan.athijegannathan at oracle.com>> wrote:
>>
>> Hi,
>>
>> I've updated webrev to include another sample (treating nio Buffer 
>> objects like arrays). Updated webrev is @ 
>> http://cr.openjdk.java.net/~sundar/8144841/webrev.01/ 
>> <http://cr.openjdk.java.net/%7Esundar/8144841/webrev.01/>
>>
>> Thanks,
>> -Sundar
>>
>> On 12/8/2015 1:31 PM, Michael Haupt wrote:
>>> Hi Sundar,
>>>
>>> lower-case thumbs up!
>>>
>>> Best,
>>>
>>> Michael
>>>
>>>> Am 07.12.2015 um 16:46 schrieb Sundararajan Athijegannathan 
>>>> <sundararajan.athijegannathan at oracle.com 
>>>> <mailto:sundararajan.athijegannathan at oracle.com>>:
>>>>
>>>> Please review http://cr.openjdk.java.net/~sundar/8144841/ 
>>>> <http://cr.openjdk.java.net/%7Esundar/8144841/> for 
>>>> https://bugs.openjdk.java.net/browse/JDK-8144841
>>>>
>>>> Adding a README for dynalink samples as Marcus suggested earlier.
>>>>
>>>> Thanks,
>>>> -Sundar
>>
>



More information about the nashorn-dev mailing list