Review request for JDK-8144914: Eagerly lookup browser JS object class in BrowserJSObjectLinker
Hannes Wallnoefer
hannes.wallnoefer at oracle.com
Mon Dec 14 16:20:51 UTC 2015
Sorry, I missed the intial request.
+1
Hannes
Am 2015-12-14 um 16:44 schrieb Attila Szegedi:
> 2nd review, please?
>
> On Tue, Dec 8, 2015 at 12:58 PM, Sundararajan Athijegannathan <
> sundararajan.athijegannathan at oracle.com> wrote:
>
>> +1
>>
>> -Sundar
>>
>>
>> On 12/8/2015 5:23 PM, Attila Szegedi wrote:
>>
>>> Please review JDK-8144914 "Eagerly lookup browser JS object class in
>>> BrowserJSObjectLinker" at <
>>> http://cr.openjdk.java.net/~attila/8144914/webrev.jdk9.jdk> for <
>>> https://bugs.openjdk.java.net/browse/JDK-8144914>
>>>
>>> (Note that line 96 replaces “return null” for “return inv” – the
>>> distinction only makes sense in presence of non-standard operations, which
>>> we currently don’t have, but even so that’s pedantically more correct.)
>>>
>>> Thanks,
>>> Attila.
>>>
>>
More information about the nashorn-dev
mailing list