Review request for JDK-8072596

A. Sundararajan sundararajan.athijegannathan at oracle.com
Thu Feb 12 15:39:06 UTC 2015


Forgot to add. Few new files have old copyright year (like 
Jdk8072596TestSubject.java). Also the samples may be restored to use 
Arrays.asList (now that you've fixed the problem)

diff -r 99cdacecab0a samples/javashell.js
--- a/samples/javashell.js    Tue Feb 10 13:10:07 2015 +0300
+++ b/samples/javashell.js    Thu Feb 12 21:08:06 2015 +0530
@@ -122,7 +122,7 @@
  // execute code command
  function exec(args) {
      // build child process and start it!
-    new ProcessBuilder(Java.to(args.split(' '), List))
+    new ProcessBuilder(Arrays.asList(args.split(' ')))
           .inheritIO()
           .start()
           .waitFor();
diff -r 99cdacecab0a samples/shell.js
--- a/samples/shell.js    Tue Feb 10 13:10:07 2015 +0300
+++ b/samples/shell.js    Thu Feb 12 21:08:06 2015 +0530
@@ -67,7 +67,7 @@
                      }
                  } else {
                      // build child process and start it!
-                    new ProcessBuilder(Java.to(args, List))
+                    new ProcessBuilder(Arrays.asList(args))
                          .inheritIO()
                          .start()
                          .waitFor();

Thanks
-Sundar

On Thursday 12 February 2015 08:58 PM, A. Sundararajan wrote:
> +1
>
> Nice work!
>
> -Sundar
>
> On Thursday 12 February 2015 12:05 AM, Attila Szegedi wrote:
>> Please review JDK-8072596 at 
>> <http://cr.openjdk.java.net/~attila/8072596/webrev.00> for 
>> <https://bugs.openjdk.java.net/browse/JDK-8072596>
>>
>> Thanks,
>>    Attila.
>



More information about the nashorn-dev mailing list