- [Approval Request] Review request for JDK-8071991

Seán Coffey sean.coffey at oracle.com
Fri Jan 30 11:07:00 UTC 2015


Looks fine. Thanks for jumping on this. Approved for jdk8u-dev. Please 
add noreg-build and 9-na labels.

regards,
Sean.

On 30/01/2015 11:05, Hannes Wallnoefer wrote:
> +1
>
>
> Am 2015-01-30 um 12:00 schrieb Attila Szegedi:
>> Please review JDK-8071991 at 
>> <http://cr.openjdk.java.net/~attila/8071991/webrev.00> for 
>> <https://bugs.openjdk.java.net/browse/JDK-8071991>
>>
>> Unfortunately, backporting JDK-8067139 bit-by-bit managed to 
>> introduce a compile error as 8u-dev Nashorn diverges from 9 Nashorn 
>> in Parser.java. I failed to notice and fix that in time, so I expect 
>> 8u-dev build now breaks. Fixing post haste. I will suggest we 
>> backport the parser changes too so this can't cause issues in the 
>> future.
>>
>> Thanks and apologies,
>>    Attila.
>



More information about the nashorn-dev mailing list