RFR 8130663: 6 fields can be static fields in Global class

A. Sundararajan sundararajan.athijegannathan at oracle.com
Tue Jul 7 11:11:45 UTC 2015


Updated: http://cr.openjdk.java.net/~sundar/8130663/webrev.01/

-Sundar

On Tuesday 07 July 2015 04:31 PM, Hannes Wallnoefer wrote:
> +1
>
> Nitpick: although 1 << 0 is redundant, we use it in various places and 
> it helps keep declaration of flags consistent, so I'd vote for keeping 
> it.
>
> Hannes
>
> Am 2015-07-07 um 12:30 schrieb A. Sundararajan:
>> Please review http://cr.openjdk.java.net/~sundar/8130663/ for 
>> https://bugs.openjdk.java.net/browse/JDK-8130663
>>
>> - made 6 fields as static in Global.java
>> - using  lazy init sentinel as location placebolder  as well
>> - few other simple code cleanups.
>>
>> Thanks,
>> -Sundar
>



More information about the nashorn-dev mailing list