RFR 8130734: Apply transformations found by netbeans Refactor->Inspect and transform menu

A. Sundararajan sundararajan.athijegannathan at oracle.com
Wed Jul 8 11:38:55 UTC 2015


Updated: http://cr.openjdk.java.net/~sundar/8130734/webrev.01/

PropertyBind.staticReadOnly field should not be made final.

- private static int staticReadOnly = 1230;

as that tries various combinations of modifiers. i.e., not using "final" 
is intended. So, revered that refactoring.

Thanks
-Sundar

On Wednesday 08 July 2015 04:40 PM, Michael Haupt wrote:
> Hi Sundar,
>
>> Am 08.07.2015 um 11:11 schrieb A. Sundararajan <sundararajan.athijegannathan at oracle.com>:
>> Please review http://cr.openjdk.java.net/~sundar/8130734/ for https://bugs.openjdk.java.net/browse/JDK-8130734
> lower-case review: there is a number of fields that are now public static final, but which have camelCase names. These could be renamed to UPPER_CASE names.
>
> * MemberInfo.myLoader
> * ScriptEngineTest.propNames
> * AbstractScriptRunnable.evaluators
> * PropertyBind.staticReadOnly
>
> Otherwise, no remarks. :-)
>
> Best,
>
> Michael
>



More information about the nashorn-dev mailing list