RFR 8130853: Non-extensible global is not handled property

Hannes Wallnoefer hannes.wallnoefer at oracle.com
Mon Jul 13 14:36:09 UTC 2015


Looks good!

Hannes

Am 2015-07-13 um 15:52 schrieb A. Sundararajan:
> Sounds good. Thanks. I'll uploaded a fresh webrev @ 
> http://cr.openjdk.java.net/~sundar/8130853/webrev.01/
>
> Thanks,
> -Sundar
>
> On Monday 13 July 2015 07:12 PM, Hannes Wallnoefer wrote:
>> addBoundProperty on Global.LexicalScope should always be called with 
>> true as extensible parameter (or call its super-method with 
>> extensible=true). LexicalScope is a declarative environment record 
>> added to the "normal" global object environment record for let-const 
>> declarations, and it can't be frozen or made non-extensible.
>>
>> A minor issue: ScriptObject#addBoundProperty javadoc for extensible 
>> param says "whether the source object is extensible or not", but it's 
>> really whether the current object is extensible or not.
>>
>> Hannes
>>
>> Am 2015-07-13 um 15:13 schrieb A. Sundararajan:
>>> Please review http://cr.openjdk.java.net/~sundar/8130853/ for 
>>> https://bugs.openjdk.java.net/browse/JDK-8130853
>>>
>>> Thanks,
>>> -Sundar
>>
>



More information about the nashorn-dev mailing list