[8u60] approval request for 8081809: Missing final modifier in method parameters (nashorn code convention)
Attila Szegedi
attila.szegedi at oracle.com
Fri Jun 5 09:13:27 UTC 2015
I approve these changes.
> On Jun 5, 2015, at 10:47 AM, Seán Coffey <sean.coffey at oracle.com> wrote:
>
> Approved pending peer code review.
>
> Regards,
> Sean.
>
> On 05/06/2015 09:44, A. Sundararajan wrote:
>> Please approve.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8081809
>> jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-June/004664.html
>> jdk8u-dev webrev: http://cr.openjdk.java.net/~sundar/8081809/8u60/webrev.00/
>>
>> Not backported 'as is' - as there are jdk9 specific classes that don't exist in jdk8u-dev. But the subset backported is backported 'as is'. I'm still CC'ing nashorn-dev.
>>
>> Thanks,
>> -Sundar
>
More information about the nashorn-dev
mailing list