RFR (S): 8080087: Nashorn $ENV.PWD is originally undefined

[Michael Haupt]

Hi -

anyway, alternative webrev: http://cr.openjdk.java.net/~mhaupt/8080087/webrev.01 - please pick. :-)

Michael

> Am 05.06.2015 um 11:57 schrieb Michael Haupt <michael.haupt at oracle.com>:
> 
> Hi Sundar,
> 
> I'm not tied to this solution. The code is as it is because it seems to be an issue of the Windows platform in particular. Would you think checking for key presence is  more robust?
> 
> Best,
> 
> Michael
> 
>> Am 05.06.2015 um 11:49 schrieb A. Sundararajan <sundararajan.athijegannathan at oracle.com>:
>> 
>> Hi,
>> 
>> Can we do
>> 
>> if (! env.containsKey(ScriptingFunctions.PWD_NAME)) {
>>   env.put(ScriptingFunctions.PWD_NAME, System.getProperty("user.dir"), scriptEnv._strict);
>> }
>> 
>> in Global.java instead of checking for Windows platform explicitly?
>> 
>> -Sundar
>> 
>> On Friday 05 June 2015 03:08 PM, Michael Haupt wrote:
>>> Dear all,
>>> 
>>> please review and sponsor this fix.
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8080087
>>> Webrev: http://cr.openjdk.java.net/~mhaupt/8080087/webrev.00
>>> 
>>> In Nashorn scripting mode, $ENV.PWD contains the current working directory. This is imported from the environment on unixy platforms. As the PWD variable is nonexistent on Windows by default, it needs to be set explicitly.
>>> 
>>> Thanks,
>>> 
>>> Michael


-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | HotSpot Compiler Team 
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment>	Oracle is committed to developing practices and products that help protect the environment