Review request for JDK-8098546: eval within a 'with' leaks definitions into global scope

A. Sundararajan sundararajan.athijegannathan at oracle.com
Mon Jun 15 13:14:01 UTC 2015


+1

Nice fix!

-Sundar

On Monday 15 June 2015 06:43 PM, Hannes Wallnoefer wrote:
> I uploaded a new webrev that overrides 
> addBoundProperties(ScriptObject, Properties[]) in WithObject instead 
> of adding code to ScriptRuntime.mergeScopes. This is a bit more 
> elegant than the previous solution.
>
> http://cr.openjdk.java.net/~hannesw/8098546/webrev.01/
>
> Hannes
>
>
> Am 2015-06-15 um 14:50 schrieb Hannes Wallnoefer:
>> Please review JDK-8098546: eval within a 'with' leaks definitions 
>> into global scope:
>>
>> http://cr.openjdk.java.net/~hannesw/8098546/
>>
>> Thanks,
>> Hannes
>



More information about the nashorn-dev mailing list