Review request for JDK-8098808: Convert Scope from interface to class
Attila Szegedi
attila.szegedi at oracle.com
Wed Jun 17 09:06:40 UTC 2015
One minor nitpick I have is that the order of arguments in the constructor for Scope is the opposite of what it was in FunctionScope; you might want to fix that before the push, but in any case it’s +1.
> On Jun 17, 2015, at 9:42 AM, Attila Szegedi <attila.szegedi at oracle.com> wrote:
>
> +1
>
>> On Jun 16, 2015, at 4:05 PM, Hannes Wallnoefer <hannes.wallnoefer at oracle.com> wrote:
>>
>> Please review JDK-8098808: Convert Scope from interface to class:
>>
>> http://cr.openjdk.java.net/~hannesw/8098808/
>>
>> Thanks,
>> Hannes
>
More information about the nashorn-dev
mailing list