RFR 8141285: NameCode should pass tests from BytecodeNameTest.java
    Attila Szegedi 
    attila.szegedi at oracle.com
       
    Tue Nov  3 14:41:13 UTC 2015
    
    
  
+1
> On Nov 3, 2015, at 3:32 PM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
> 
> Also piggybacking to add a sample (find_underscores.js)
> 
> -Sundar
> 
> On 11/3/2015 8:01 PM, Sundararajan Athijegannathan wrote:
>> Please review http://cr.openjdk.java.net/~sundar/8141285/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8141285
>> 
>> NameCodec has similar functionality (with a minor bug in '\' handling) as in sun.invoke.util.BytecodeName.java (which seems to be old code, but unused in jdk repo!). Using code in BytecodeName.java in NameCodec.java now - only minimal subset needed for decode, encode. Also, adding tests for NameCodec.java derived from (older) mlvm test BytecodeNameTest.java
>> 
>> Thanks,
>> -Sundar
> 
    
    
More information about the nashorn-dev
mailing list