Review request for JDK-8142864: Raw types warning in WeakValueCache

Marcus Lagergren marcus at lagergren.net
Wed Nov 18 11:07:15 UTC 2015


+1

> On 12 Nov 2015, at 16:36, Hannes Wallnoefer <hannes.wallnoefer at oracle.com> wrote:
> 
> Please review JDK-8142864: Raw types warning in WeakValueCache:
> 
> http://cr.openjdk.java.net/~hannesw/8142864/webrev/
> 
> This removes a warning in WeakValueCache.java, and I also reduced methods by combining code as suggested by Attila.
> 
> Furthermore I renamed method in isWrappedPrimitiveAndObject in ScriptRuntime.java to isPrimitiveAndObject because the primitives are not wrapped (at least not in the JavaScript meaning of the word).
> 
> Thanks,
> Hannes



More information about the nashorn-dev mailing list