Review request for JDK-8144131: ArrayData.getInt implementations do not convert to int32

Marcus Lagergren marcus at lagergren.net
Mon Nov 30 08:25:12 UTC 2015


I’m perfectly fine with the combined fix. Looking good.

+1

/M

> On 27 Nov 2015, at 09:03, Hannes Wallnoefer <hannes.wallnoefer at oracle.com> wrote:
> 
> Please review JDK-8144131: ArrayData.getInt implementations do not convert to int32:
> 
> http://cr.openjdk.java.net/~hannesw/8144131/webrev/
> 
> for https://bugs.openjdk.java.net/browse/JDK-8144131
> 
> I piggybacked a small fix to keep unary plus/minus from changing the type of long literals to doubles. I'm not sure if that is serious enough that it should get its own bug, let me know if you think so.
> 
> Hannes



More information about the nashorn-dev mailing list