RFR: JDK-8137281: OutOfMemoryError with large numeric keys in JSON.parse

Marcus Lagergren marcus at lagergren.net
Mon Oct 5 08:00:31 UTC 2015


Happy with that. +1

/M

> On 05 Oct 2015, at 09:43, Hannes Wallnoefer <hannes.wallnoefer at oracle.com> wrote:
> 
> Thanks Marcus.
> 
> Actually the lower threshold does not affect any script in Octane or Sunspider. When you set it so low that it starts being used more it really hurts performance, but 1 million is still pretty high while allowing us to keep a few of these in memory at a time.
> 
> Hannes
> 
> 
> Am 2015-10-05 um 09:25 schrieb Marcus Lagergren:
>> +1. No regressions everywhere on e.g. Octane? I have a feeling we bumped that buffer up to 8 megs for performance reasons. For the general case, this is of course way too much.
>> 
>> /M
>> 
>>> On 02 Oct 2015, at 13:08, Hannes Wallnoefer <hannes.wallnoefer at oracle.com> wrote:
>>> 
>>> Please review JDK-8137281: OutOfMemoryError with large numeric keys in JSON.parse:
>>> 
>>> http://cr.openjdk.java.net/~hannesw/8137281/webrev/
>>> 
>>> Thanks,
>>> Hannes
> 



More information about the nashorn-dev mailing list