Review request for JDK-8139282: Remove @author and @id tags from Dynalink JavaDoc; some minor edits
Attila Szegedi
attila.szegedi at oracle.com
Mon Oct 12 08:36:13 UTC 2015
Thanks. I will go through the documentation and add SecurityException where necessary in a later separate JavaDoc patch. You are right about webrev showing other changes too. I fixed that, updating it in-place.
Thanks,
Attila.
> On Oct 12, 2015, at 5:42 AM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
>
> Wherever SecurityException is thrown, javadoc could have @throws and one line explanation. Even though it is a RuntimeException, JDK javadoc elsewhere documents SecurityException explicitly.
>
> Other than that +1
>
> PS. This webrev shows differences due to other patches/fixes as well ...
>
> -Sundar
>
>
> On 10/9/2015 6:44 PM, Attila Szegedi wrote:
>> Please review JDK-8139282 "Remove @author and @id tags from Dynalink JavaDoc; some minor edits" at <http://cr.openjdk.java.net/~attila/8139282/webrev.jdk9> for <https://bugs.openjdk.java.net/browse/JDK-8139282>
>>
>> This is a very trivial and boring change, it’s mostly what it says: removing the @author and @id tags; I also made some minor rewording edits (that will likely be further changed by later more major JavaDoc edits anyway).
>>
>> Thanks,
>> Attila.
>
More information about the nashorn-dev
mailing list