Review request for JDK-8139590: Improve Dynalink JavaDoc

Hannes Wallnoefer hannes.wallnoefer at oracle.com
Fri Oct 16 15:49:49 UTC 2015


Looks good. A few minor issues I found:

- GuardedInvocation.java class javadoc: "as long as the switch point is 
not invalidated" should be plural.
- LinkRequest.java #getReceiver: I think "first argument" would be more 
intuitive than "0th argument".
- BeansLinker.java class javadoc last sentence: "The class also allows 
exposes...": remove "allows"

Hannes

Am 2015-10-14 um 15:48 schrieb Attila Szegedi:
> Please review JDK-8139590 "Improve Dynalink JavaDoc" at <http://cr.openjdk.java.net/~attila/8139590/webrev.jdk9> for <https://bugs.openjdk.java.net/browse/JDK-8139590>
>
> Notes:
> - webrev also shows some previous issues in the history of some of the files, but the changes for those issue are not in the diffs.
> - In addition to JavaDoc, there are some minor additional fixes:
>    - GuardedInvocation.assertType was removed; it has shown up in JavaDoc, but it was not used except for one place in TypeConverterFactory, and even there it wasn’t needed
>    - GuardedInvocation had an accidental dependency on jdk.nashorn.internal.* class; that was eliminated.
>    - AbstractCallSiteDescriptor.lookupsEqual and lookupHashCode now handle nulls
>    - CompositeGuardingDynamicLinker and TypeBasedCompositeGuardingDynamicLinker detect if any of its composites are null and throw a NPE
>
> Thanks,
>    Attila.



More information about the nashorn-dev mailing list