Review request for JDK-8139435: Make sure CallSiteDescriptor.getLookup is subject to a security check
Hannes Wallnoefer
hannes.wallnoefer at oracle.com
Mon Oct 19 15:18:30 UTC 2015
Am 2015-10-19 um 08:29 schrieb Attila Szegedi:
>> On Oct 16, 2015, at 5:11 PM, Hannes Wallnoefer <hannes.wallnoefer at oracle.com> wrote:
>>
>> What's the rationale for providing the static lookupEquals and lookupHashCode methods in AbstractCallSiteDescriptor instead of just putting the code in non-abstract instance methods? This way it's a bit more flexible, but I'm not sure it warrants the additional API surface.
> I agree that the API surface increase is not great. The idea was to externalize into subclasses anything that needs access to the lookup object instead of providing access to the lookup object in a superclass. But in the end, that’s actually a better idea (as Sundar pointed out). Fortunately, another changeset coming soon will fix this by making CallSiteDescriptor into a class instead of an interface, and then reduce the API surface back (and eventually eliminate all subclasses and just leave CallSiteDescriptor).
Thanks for the explanation, sounds good.
Hannes
More information about the nashorn-dev
mailing list