Review request for JDK-8139888: Improve Dynalink JavaDoc some more

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Tue Oct 20 03:49:37 UTC 2015


* File: 
http://cr.openjdk.java.net/~attila/8139888/webrev.jdk9/src/jdk.scripting.nashorn/share/classes/jdk/internal/dynalink/DynamicLinkerFactory.java.udiff.html

"they are themselves" -> "these are" ?

+1

-Sundar


On 10/19/2015 8:04 PM, Attila Szegedi wrote:
> Please review JDK-8139888 "Improve Dynalink JavaDoc some more" at <http://cr.openjdk.java.net/~attila/8139888/webrev.jdk9> for <https://bugs.openjdk.java.net/browse/JDK-8139888>
>
> This is the last anticipated JavaDoc focused changeset.
>
> In addition to JavaDoc improvements, there are few minor changes:
> - DynamicLinkerFactory rejects nulls in lists of linkers being passed
> - LinkRequest.replaceArguments was made variable arity (taking Object… as its last arg instead of Object[]), making it consistent with SipleLinkRequest constructor
> - SimpleLinkRequest rejects nulls in constructor parameters now, and clones incoming arguments lists
> - Lookup and NameCodec classes were made final
>   
> Thanks,
>    Attila.



More information about the nashorn-dev mailing list