Review request for JDK-8139905: Add a convenience AccessControlContext factory

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Tue Oct 20 08:25:14 UTC 2015


+1

-Sundar

On 10/20/2015 1:54 PM, Attila Szegedi wrote:
> Updated the webrev in-place to reflect the AccessControlContextFactory is now in jdk.nashorn.internal.runtime.
>
> Attila.
>
>> On Oct 20, 2015, at 10:13 AM, Attila Szegedi <attila.szegedi at oracle.com> wrote:
>>
>> There’s actually IntDeque and AssertsEnabled in jdk.nashorn.internal. OTOH, all its users are themselves in internal.runtime.* package space, so it doesn’t hurt to move it there - will do that.
>>
>> Attila.
>>
>>> On Oct 20, 2015, at 5:34 AM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
>>>
>>> +1
>>>
>>> PS. Should the nashorn's AccessControlContextFactory be under jdk.nashorn.internal.runtime? I think this is the first class under jdk.nashorn.internal...
>>>
>>> -Sundar
>>>
>>> On 10/20/2015 12:03 AM, Attila Szegedi wrote:
>>>> Please note that there’s two AccessControlContextFactory classes; it’s unfortunate, but we’ll be separating Dynalink from Nashorn, and while Nashorn can rely on Dynalink, we don’t want to expose the ACC factory from Dynalink, so lacking a better place, we’ll duplicate this small utility for now.
>>>>
>>>> Attila.
>>>>
>>>>> On Oct 19, 2015, at 8:07 PM, Attila Szegedi <attila.szegedi at oracle.com> wrote:
>>>>>
>>>>> Please review JDK-8139905 "Add a convenience AccessControlContext factory" at <http://cr.openjdk.java.net/~attila/8139905/webrev.jdk9> for <https://bugs.openjdk.java.net/browse/JDK-8139905>
>>>>>
>>>>> Thanks,
>>>>> Attila.



More information about the nashorn-dev mailing list