Review request for JDK-8139931: Introduce Operation objects in Dynalink instead of string encoding

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Tue Oct 20 08:52:46 UTC 2015


* StandardOperation.java is missing copyright.

* NamedOperation.java is missing copyright.

* CompositeOperation.java is missing copyright.

* Can CompositeOperation be final?

* Unrelated ArrayData change? Unused method?

* NashornCallSiteDescriptor may have explanation as to why 18 bits are 
sufficient for "program point" [now that flag bits are used for encoding 
operation enums as well]

That's all I could find...

+1

-Sundar

On 10/20/2015 1:41 PM, Attila Szegedi wrote:
> Please review JDK-8139931 "Introduce Operation objects in Dynalink instead of string encoding" at <http://cr.openjdk.java.net/~attila/8139931/webrev.jdk9> for <https://bugs.openjdk.java.net/browse/JDK-8139931>
>
> This is admittedly a big one. It is also the last in the pipeline of the internal Dynalink cleanups, so we’ve reached the end of that!
>
> Thanks,
>    Attila.



More information about the nashorn-dev mailing list