Review request for JDK-8139884: Use privileged blocks when working with class loaders

Attila Szegedi attila.szegedi at oracle.com
Tue Oct 20 09:30:33 UTC 2015


Hi Michael,

I agree with that in general. I’m using lambdas for doPrivileged here and there; in fact my initial version of the code used them, but then I changed them back to explicit PrivilegedAction objects as this particular change looks like a candidate for backporting to 8u-dev and there we unfortunately can’t use lambdas because of Nashorn’s “-source 1.7” requirement, so I’ll avoid them here.

Attila.

> On Oct 19, 2015, at 4:33 PM, Michael Haupt <michael.haupt at oracle.com> wrote:
> 
> Hi Attila,
> 
> lower-case thumbs up, with just the remark that lambdas could make the code more concise.
> 
> Best,
> 
> Michael
> 
>> Am 19.10.2015 um 15:53 schrieb Attila Szegedi <attila.szegedi at oracle.com>:
>> 
>> Please review JDK-8139884 "Use privileged blocks when working with class loaders" at <http://cr.openjdk.java.net/~attila/8139884/webrev.jdk9> for <https://bugs.openjdk.java.net/browse/JDK-8139884>
>> 
>> Thanks,
>> Attila.
> 
> 



More information about the nashorn-dev mailing list