[PATCH] Some typos

Ahmed Ashour asashour at yahoo.com
Fri Sep 11 06:33:50 UTC 2015


Hi Sundar,
Eclipse has automatic highlight of potential spelling mistakes, you just need to go through the code.
In the other comments I mistyped, and it should be:     - 'behaviour' could be 'behavior': there are three places.    - WarnCallback: references '@gmail.com' in @author, this is the only place, which looks strange.


Thanks again,Ahmed
      From: Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com>
 To: nashorn-dev at openjdk.java.net 
 Sent: Friday, September 11, 2015 5:50 AM
 Subject: Re: [PATCH] Some typos
   
Hi Ahmed,

Thanks for submitting this patch. I've filed 
https://bugs.openjdk.java.net/browse/JDK-8136349

PS. Did you find these while reading code or used any automation/tool to 
find spelling issues? Just curious..

Thanks,
-Sundar

On 9/11/2015 1:36 AM, Ahmed Ashour wrote:
> Dear all,
>
> Please find below patch, which:
>    - Handles some typos
>    - Removes unused imports from two files.
>
> Also, there are other potential places to modify (if appropriate):
>    - WarnCallback: references '@gmail.com' in @author, this is the 
> only place, which looks strange.
>    - 'behavior' could be 'behavior': there are three places.
>
> Hope you find it useful.
>
> Yours,
> Ahmed

  


More information about the nashorn-dev mailing list