[PATCH] Some typos
Marcus Lagergren
lagergren at gmail.com
Fri Sep 11 09:04:15 UTC 2015
I think we use American English as the standard. It says “optimization” everywhere, for example. Also “color”. Thus, it should probably remain “behavior”.
/M
> On 11 Sep 2015, at 09:31, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
>
> Hi Ahmed,
>
> Thanks. NetBeans has similar feature - but that means opening and reading/looking at each file. I thought if there is any automated way to search for all typos across files of a project or a directory.
>
> * behaviour / behavior being British / American spelling, I'd rather leave it..
>
> * I'll check out @gmail.com in @author
>
> Thanks,
> -Sundar
>
>
> On 9/11/2015 12:03 PM, Ahmed Ashour wrote:
>> Hi Sundar,
>> Eclipse has automatic highlight of potential spelling mistakes, you just need to go through the code.
>> In the other comments I mistyped, and it should be: - 'behaviour' could be 'behavior': there are three places. - WarnCallback: references '@gmail.com' in @author, this is the only place, which looks strange.
>>
>>
>> Thanks again,Ahmed
>> From: Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com>
>> To: nashorn-dev at openjdk.java.net
>> Sent: Friday, September 11, 2015 5:50 AM
>> Subject: Re: [PATCH] Some typos
>> Hi Ahmed,
>>
>> Thanks for submitting this patch. I've filed
>> https://bugs.openjdk.java.net/browse/JDK-8136349
>>
>> PS. Did you find these while reading code or used any automation/tool to
>> find spelling issues? Just curious..
>>
>> Thanks,
>> -Sundar
>>
>> On 9/11/2015 1:36 AM, Ahmed Ashour wrote:
>>> Dear all,
>>>
>>> Please find below patch, which:
>>> - Handles some typos
>>> - Removes unused imports from two files.
>>>
>>> Also, there are other potential places to modify (if appropriate):
>>> - WarnCallback: references '@gmail.com' in @author, this is the
>>> only place, which looks strange.
>>> - 'behavior' could be 'behavior': there are three places.
>>>
>>> Hope you find it useful.
>>>
>>> Yours,
>>> Ahmed
>>
>
More information about the nashorn-dev
mailing list