RFR 8136349: Typos patch for nashorn sources submitted on Sep 10, 2015
Sundararajan Athijegannathan
sundararajan.athijegannathan at oracle.com
Fri Sep 11 10:16:41 UTC 2015
Thanks for all the reviews! Ahmed, thanks for your contribution!
http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/c13179703f65
PS. Pushed changes in webrev.01 @
http://cr.openjdk.java.net/~sundar/8136349/webrev.01/
Thanks
-Sundar
On 9/11/2015 3:26 PM, Attila Szegedi wrote:
> +1 - I have already reviewed the .01 webrev.
>
>> On Sep 11, 2015, at 9:52 AM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
>>
>> Please review http://cr.openjdk.java.net/~sundar/8136349/ for https://bugs.openjdk.java.net/browse/JDK-8136349
>>
>> This is a contribution by Ahmed Ashour. Please see this thread -> http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-September/005206.html
>>
>> This webrev was generated by after applying Ahmed's patch & then fixing the following manually on top of that:
>>
>> 1) File: NativeRegExp.java
>>
>> preceds -> precedes
>>
>> 2) File: CompiledFunction.java
>>
>> rest of -> "restOf" - this is a reference to "restOf" methods generated and so should not be "rest of".
>>
>> Thanks,
>> -Sundar
More information about the nashorn-dev
mailing list