[8u] RFR 8055917: jdk.nashorn.internal., , codegen, , .CompilationPhase$N should be renamed to proper classes

[Attila Szegedi]

I’d achieve the same effect by changing CompilationPhase to be a regular class instead of an enum, and creating named inner classes.

While we’re at it, let’s also rename “BuiltinTransform” to something closer to “ApplySpecialization”.

For bonus points, you might consider removing CompilationState altogether. CompilationState serves no functional purpose just to ensure that a phase only runs when it's preceding states did. In fact, some compilation phases have been added since that don’t even bother updating CompilationState anymore, so it’s effectively abandoned.

Attila.

[9/14/15, 9:39:54 AM] Attila Szegedi: but we guarantee that with the construction of phases in Compiler.java anyway
> On Sep 14, 2015, at 9:04 AM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
> 
> Please review http://cr.openjdk.java.net/~sundar/8055917/ for https://bugs.openjdk.java.net/browse/JDK-8055917
> 
> PS. Piggybacking few cleanups in samples and also adding 2 new samples.
> 
> Thanks,
> -Sundar