RFR 8136544: Call site switching to megamorphic causes incorrect property read

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Wed Sep 16 10:46:28 UTC 2015


Hi,

* Changed NativeJavaImporter param name.
* Commented on magic upper limit in ScopeTest.
* Also added a .js test that explicitly sets the dynalink threshold and 
uses a limit slightly beyond that

http://cr.openjdk.java.net/~sundar/8136544/webrev.01/

Thanks
-Sundar

On 9/16/2015 2:05 PM, Michael Haupt wrote:
> Hi Sundar,
>
> lower-case thumbs up, with two remarks:
> * the new boolean argument in NativeJavaImporter should be called 
> isScope, not isStrict
> * ScopeTest could better illustrate the conditions it tests if it used 
> a symbolic constant instead of 16 ("magic number") - can the 
> megamorphism threshold be queried from the engine?
>
> Best,
>
> Michael
>
>> Am 16.09.2015 um 06:27 schrieb Sundararajan Athijegannathan 
>> <sundararajan.athijegannathan at oracle.com 
>> <mailto:sundararajan.athijegannathan at oracle.com>>:
>>
>> Please review http://cr.openjdk.java.net/~sundar/8136544/ 
>> <http://cr.openjdk.java.net/%7Esundar/8136544/> for 
>> https://bugs.openjdk.java.net/browse/JDK-8136544
>>
>> Thanks,
>> -Sundar
>
> -- 
>
> Oracle <http://www.oracle.com/>
> Dr. Michael Haupt | Principal Member of Technical Staff
> Phone: +49 331 200 7277 | Fax: +49 331 200 7561
> OracleJava Platform Group | LangTools Team | Nashorn
> Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, 
> Germany
> Green Oracle <http://www.oracle.com/commitment> 	Oracle is committed 
> to developing practices and products that help protect the environment
>
>



More information about the nashorn-dev mailing list