Review request for JDK-8134502: introduce abstraction for basic NodeVisitor usage

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Mon Sep 28 07:33:49 UTC 2015


+1 on backport changes..


On 9/28/2015 12:24 PM, Attila Szegedi wrote:
> Thanks for the review folks; can I quickly get a review for the 8u-dev backport at <http://cr.openjdk.java.net/~attila/8134502/webrev.jdk8u-dev>?
>
> The changes from jdk9 are:
> - Parser API changes are omitted
> - RecompilableScriptFunctionData.java Hunk #2 failed to apply solely because its context is different ("IdentityHashMap<Symbol, Boolean>” in 8 vs. "IdentityHashMap<>" in 9 on the line preceding the change).
>
> Thanks,
>    Attila.
>
>> On Sep 27, 2015, at 12:05 PM, Marcus Lagergren <marcus at lagergren.net> wrote:
>>
>> +1
>>
>>> On 25 Sep 2015, at 18:54, Attila Szegedi <attila.szegedi at oracle.com> wrote:
>>>
>>> Please review JDK-8134502 "introduce abstraction for basic NodeVisitor usage" at <http://cr.openjdk.java.net/~attila/8134502/webrev.jdk9> for <https://bugs.openjdk.java.net/browse/JDK-8134502>
>>>
>>> Thanks,
>>> Attila.



More information about the nashorn-dev mailing list