Review request for JDK-8149451: Fix bytecode generation issue after 8149186

Jim Laskey (Oracle) james.laskey at oracle.com
Thu Feb 11 12:32:10 UTC 2016


+1


> On Feb 11, 2016, at 8:28 AM, Attila Szegedi <szegedia at gmail.com> wrote:
> 
> Please review JDK-8149451 "Fix bytecode generation issue after 8149186" at <http://cr.openjdk.java.net/~attila/8149451/webrev.jdk9> for <https://bugs.openjdk.java.net/browse/JDK-8149451>
> 
> This changeset is basically identical to JDK-8149186 but it will allow optimistic addition on booleans. I have implemented it by delegating to Type.INT.add instead of copy-pasting the code, but that should not cause issues (famous last words, right?). If you have the opportunity to re-test on Linux, that'd be appreciated (I have no Linux machines around).
> 
> Thanks,
>  Attila.



More information about the nashorn-dev mailing list