RFR(S): 8148140: arguments are handled differently in apply for JS functions and AbstractJSObjects

Attila Szegedi szegedia at gmail.com
Sun Feb 28 03:05:14 UTC 2016


Sorry, late to the party here, but it seems to me that there’s a discrepancy between the path <test/src/jdk/nashorn/api/scripting/test/JDK_8148140_Test.java> and the "package jdk.nashorn.internal.runtime.test" declaration it contains.

> On Feb 16, 2016, at 3:40 PM, Michael Haupt <michael.haupt at oracle.com> wrote:
> 
> Dear all,
> 
> please review this fix.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8148140
> Webrev: http://cr.openjdk.java.net/~mhaupt/8148140/webrev.00/
> 
> The change fixes apply calls for functions defined as JSObjects by treating them like vararg calls (the arguments are passed in an array). Prior to the change, the code used to always collect arguments in an array, which led to apply calls being passed an array containing the argument array as the sole argument.
> 
> Piggybacked: added copyright notice for one test.
> 
> Thanks,
> 
> Michael
> 
> -- 
> 
> <http://www.oracle.com/>
> Dr. Michael Haupt | Principal Member of Technical Staff
> Phone: +49 331 200 7277 | Fax: +49 331 200 7561
> Oracle Java Platform Group | LangTools Team | Nashorn
> Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany
> 
> ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 München
> Registergericht: Amtsgericht München, HRA 95603
> 
> Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
> Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
> Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
> <http://www.oracle.com/commitment>	Oracle is committed to developing practices and products that help protect the environment
> 



More information about the nashorn-dev mailing list