Review request for JDK-8150218: Autoconversion SAM adapters sometimes don't get privileges
Michael Haupt
michael.haupt at oracle.com
Mon Feb 29 08:38:07 UTC 2016
Hi Attila,
> Am 28.02.2016 um 04:37 schrieb Attila Szegedi <szegedia at gmail.com>:
> Please review JDK-8150218 "Autoconversion SAM adapters sometimes don't get privileges" at <http://cr.openjdk.java.net/~attila/8150218/webrev.jdk9> for <https://bugs.openjdk.java.net/browse/JDK-8150218>
lower-case thumbs up, with one remark about SecureLookupSupplier, lines 57/58: not sure the exact same text is really needed twice. :-)
There also is a little webrev issue: the change for ScriptUtils.java is empty in the webrev, but appears in the patch. It seems this is because the change in that file is simply the removal of a single space character.
Best,
Michael
--
<http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany
ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
<http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
More information about the nashorn-dev
mailing list