Review request for JDK-8143896: java.lang.Long is implicitly converted to double

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Mon Jan 4 04:00:08 UTC 2016


I think I already commented on this webrev -- that we need to cover 
tests for BigInteger, BigDecimal.

Also, I'm not sure linking Double and Int by nashorn  primitive linkers 
is the right solution. AtomicInteger, DoubleAdder etc. are all Number 
subtypes. We return "number" when typeof is used on any Number subtype.
Now, that means JS code will see these as 'number' type objects -- yet 
Number.prototype methods won't work on those!! I know this is hard 
problem -- we also have another (somewhat related) BigDecimal, 
BigInteger toString / String conversion issue. We need to discuss this.

-Sundar

On 1/2/2016 8:29 PM, Attila Szegedi wrote:
> +1
>
>> On Dec 18, 2015, at 3:54 PM, Hannes Wallnoefer <hannes.wallnoefer at oracle.com> wrote:
>>
>> Please review JDK-8143896: java.lang.Long is implicitly converted to double
>>
>> http://cr.openjdk.java.net/~hannesw/8143896/webrev/
>>
>> Thanks,
>> Hannes



More information about the nashorn-dev mailing list