Review request for JDK-8144917: Prepare AbstractJavaLinker/BeanLinker codebase for missing member implementation

Michael Haupt michael.haupt at oracle.com
Mon Jan 11 10:18:57 UTC 2016


Hi Attila,

lower-case thumbs-up, with one remark: AbstractJavaLinker.getNextComponent(ComponentLinkRequest) could be rewritten like so (matching patterns applied elsewhere in the patch):

GuardedInvocationComponent getNextComponent(final ComponentLinkRequest req) throws Exception {
    if (!req.operations.isEmpty()) {
        final GuardedInvocationComponent gic = getGuardedInvocationComponent(req);
        return gic != null ? gic : getNextComponent(req.popOperations());
    }
    return null;
}

Best,

Michael

> Am 23.12.2015 um 21:30 schrieb Attila Szegedi <szegedia at gmail.com>:
> 
> Please review JDK-8144917 "Prepare AbstractJavaLinker/BeanLinker codebase for missing member implementation" at <http://cr.openjdk.java.net/~attila/8144917/webrev.jdk9> for <https://bugs.openjdk.java.net/browse/JDK-8144917>
> 
> This change has no functional effects, it's a refactoring for easier introduction of the no-such-member implementation (JDK-8144919), a review for which will immediately follow. I only plan to commit the two together after they have been both reviewed.
> 
> Thanks,
>  Attila.

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment>	Oracle is committed to developing practices and products that help protect the environment



More information about the nashorn-dev mailing list