Review request for JDK-8146274: Thread spinning on WeakHashMap.getEntry() with concurrent use of nashorn

Michael Haupt michael.haupt at oracle.com
Fri Jan 15 12:48:56 UTC 2016


Hi Hannes,

lower-case thumbs up, with two remarks on the doc changes:

-Object.prototype.toString=returns a string representing of this object
+Object.prototype.toString=returns a string representation this object
 
... should be "... of this object"

Likewise, for
+Function.prototype.toString=returns a string representation this function

Best,

Michael

> Am 15.01.2016 um 12:49 schrieb Hannes Wallnoefer <hannes.wallnoefer at oracle.com>:
> 
> Please review:
> 
> Webrev: http://cr.openjdk.java.net/~hannesw/8146274/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8146274
> 
> I was not able to reproduce the issue although I tried my best to follow the instructions. However, it is pretty clear that the issue is that the cause for the concurrent modification exception is the sharing of  WeakPropertyMapSets between PropertyMapListeners.
> 
> Thanks,
> Hannes

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment>	Oracle is committed to developing practices and products that help protect the environment



More information about the nashorn-dev mailing list