RFR(M): 8144113: enable jjs testing

Michael Haupt michael.haupt at oracle.com
Wed Jan 20 13:28:03 UTC 2016


Hi Attila,

indeed the "ant test" task will fail for those tests that rely on Cygwin binaries when executed from the cmd.exe shell prompt. The number of tests that do so is minuscule. Still, since tests failing in such circumstances is untidy, these should be enabled for Win/Cygwin only. Filed as https://bugs.openjdk.java.net/browse/JDK-8147788.

Best,

Michael

> Am 20.01.2016 um 12:05 schrieb Attila Szegedi <szegedia at gmail.com>:
> Nice. Although, it is obvious Cygwin would provide a “which". Are our Windows tests supposed to run on Cygwin only, not on vanilla Windows?
> 
>> On Jan 20, 2016, at 9:49 AM, Michael Haupt <michael.haupt at oracle.com> wrote:
>> 
>> Hi Attila,
>> 
>> in addition to Sundar's remark about this only being a @subtest, I can report successful execution of "which" on Cygwin. :-)
>> 
>> Best,
>> 
>> Michael
>> 
>>> Am 19.01.2016 um 15:04 schrieb Attila Szegedi <szegedia at gmail.com>:
>>> 
>>> Wouldn't test/script/nosecurity/jjs-common.js.html also need @runif os.not.windows? It executes “which”, which I seem to remember doesn’t exist on Windows. (Windows has “where” instead, which might or might not be good enough; I don’t know…)
>>> 
>>>> On Jan 19, 2016, at 2:56 PM, Michael Haupt <michael.haupt at oracle.com> wrote:
>>>> 
>>>> Dear all,
>>>> 
>>>> please review this change by Srinivas Dama, which I'm sponsoring.
>>>> RFE: https://bugs.openjdk.java.net/browse/JDK-8144113
>>>> Webrev: http://cr.openjdk.java.net/~mhaupt/8144113/webrev.00
>>>> 
>>>> The change contains some tests for the jjs executable. They are implemented in JavaScript themselves and extensively use the scripting capabilities of Nashorn. 
>>>> 
>>>> Thanks,
>>>> 
>>>> Michael


-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment>	Oracle is committed to developing practices and products that help protect the environment



More information about the nashorn-dev mailing list