Review request for JDK-8147845: Varargs Array functions still leaking longs

Hannes Wallnoefer hannes.wallnoefer at oracle.com
Thu Jan 21 10:59:42 UTC 2016


Thanks for the review. I propose to rename that method to 
"toNarrowestNumber", which also reflects better what it does. Does that 
sound ok?

Hannes

Am 2016-01-21 um 11:12 schrieb Sundararajan Athijegannathan:
> +1
>
> PS. Minor: toNumber overload accepting long and returning Number is 
> bit confusing. Too many toNumber overloads and a overload returning a 
> different type...
>
> -Sundar
>
> On 1/21/2016 3:21 PM, Hannes Wallnoefer wrote:
>> Please review JDK-8147845: Varargs Array functions still leaking longs:
>>
>> webrev: http://cr.openjdk.java.net/~hannesw/8147845/webrev/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8147845
>>
>> Thanks,
>> Hannes
>



More information about the nashorn-dev mailing list