RFR 8149929: Nashorn Parser API needs to be updated for ES6

[Sundararajan Athijegannathan]

Thanks for the review! Fixed ParserImpl.java to use Arrays.copyOf as
suggested:

http://cr.openjdk.java.net/~sundar/8149929/webrev.01

Thanks,

-Sundar

On 7/12/2016 5:59 PM, Michael Haupt wrote:
> Hi Sundar,
>
> congratulations on a titanic achievement. :-) Thumbs up, with one
> really minor remark.
>
> In ParserImpl, the two first lines here ...
>
> +        String[] newArgs = new String[args.length + 1];
> +        System.arraycopy(args, 0, newArgs, 0, args.length);
> +        newArgs[args.length] = "--parse-only";
>
> ... could be replaced with ...
>
> String[] newArgs = Arrays.copyOf(args.length + 1);
>
> ... just to make the code look a bit less like assembler. :-)
>
> Best,
>
> Michael
>
>> Am 12.07.2016 um 07:31 schrieb Sundararajan Athijegannathan
>> <sundararajan.athijegannathan at oracle.com
>> <mailto:sundararajan.athijegannathan at oracle.com>>:
>>
>> Please review http://cr.openjdk.java.net/~sundar/8149929/webrev.00/
>> <http://cr.openjdk.java.net/%7Esundar/8149929/webrev.00/> for
>> https://bugs.openjdk.java.net/browse/JDK-8149929
>>
>> Nashorn Parser JEP (http://openjdk.java.net/jeps/236) added Parser API
>> for ECMAScript ES5.1 version. The current fix is to update the Parser
>> API for ECMAScript 6.
>>
>> Specdiff for specification changes is here:
>> http://cr.openjdk.java.net/~sundar/8149929/specdiff/overview-summary.html
>>
>> Thanks,
>>
>> -Sundar
>>
>>
>
> -- 
>
> Oracle <http://www.oracle.com/>
> Dr. Michael Haupt | Principal Member of Technical Staff
> Phone: +49 331 200 7277 | Fax: +49 331 200 7561
> Oracle Java Platform Group | LangTools Team | Nashorn
> Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467
> Potsdam, Germany
>
> ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25,
> D-80992 München
> Registergericht: Amtsgericht München, HRA 95603
>
> Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering
> 163/167, 3543 AS Utrecht, Niederlande
> Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
> Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
> Green Oracle <http://www.oracle.com/commitment> 	Oracle is committed
> to developing practices and products that help protect the environment
>
>