RFR:8158817

Hannes Wallnöfer hannes.wallnoefer at oracle.com
Wed Jun 15 11:47:01 UTC 2016


Hi Srini,

„it self“ should be a single word in Math.ceil and Math.floor. Otherwise looks good.

Hannes


> Am 15.06.2016 um 13:21 schrieb Michael Haupt <michael.haupt at oracle.com>:
> 
> Hi Srini,
> 
> lower-case thumbs up, with these corrections:
> * Math.ceil, Math.floor: ... returns argument it self ... -> ... returns argument itself ...
> * Math.random, Math.sin: insert space after comma
> 
> Best,
> 
> Michael
> 
>> Am 15.06.2016 um 08:54 schrieb Srinivas Dama <srinivas.dama at oracle.com>:
>> 
>> Hi,
>> 
>> Please review
>> http://cr.openjdk.java.net/~sdama/8158817/webrev.00/ 
>> for https://bugs.openjdk.java.net/browse/JDK-8158817 
>> 
>> Regards,
>> Srinivas
> 
> -- 
> 
> <http://www.oracle.com/>
> Dr. Michael Haupt | Principal Member of Technical Staff
> Phone: +49 331 200 7277 | Fax: +49 331 200 7561
> Oracle Java Platform Group | LangTools Team | Nashorn
> Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany
> 
> ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 München
> Registergericht: Amtsgericht München, HRA 95603
> 
> Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
> Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
> Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
> <http://www.oracle.com/commitment>	Oracle is committed to developing practices and products that help protect the environment
> 



More information about the nashorn-dev mailing list